Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(konnect): add namespace in KonnectNamespacedRef #82

Merged
merged 3 commits into from
Sep 20, 2024
Merged

feat(konnect): add namespace in KonnectNamespacedRef #82

merged 3 commits into from
Sep 20, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Sep 18, 2024 •
edited
Loading

What this PR does / why we need it:
Add namespace in konnectNamespacedRef because some of Kong entities like KongVault and KongClusterPlugin are cluster scoped and they require the namespace for referring to a Konnect gateway controlplane.
Which issue this PR fixes

#36

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey added this to the KGO 1.4 milestone Sep 18, 2024
@randmonkey randmonkey self-assigned this Sep 18, 2024
@randmonkey randmonkey requested a review from a team as a code owner September 18, 2024 09:02
pmalek
pmalek requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we've decided to not implement cross namespace references.

Kong/gateway-operator#524 for example has been put into 'post-GA' part of the epic.

Let's first solve the immediate scope from Kong/gateway-operator#370 (for October's release).

LMKWYT

@randmonkey
Copy link
Contributor Author

For now we've decided to not implement cross namespace references.

Kong/gateway-operator#524 for example has been put into 'post-GA' part of the epic.

Let's first solve the immediate scope from Kong/gateway-operator#370 (for October's release).

LMKWYT

KongVault is also cluster scoped. If we do not want to add namespace, it should also be moved out of KGO 1.4 scope.

@randmonkey randmonkey requested a review from pmalek September 18, 2024 09:19
@pmalek
Copy link
Member

pmalek commented Sep 18, 2024

Left a comment about this in https://kongstrong.slack.com/archives/C079GK3KB9R/p1726654138359599.

IMHO we should prevent using cross-namespace refs until we implement proper handling of those. In order to move forward with Vaults, let's review and merge this but at the same time let's add CEL validation rules to other types that will prevent users from using cross namespace ref in non cluster scoped resources.

@randmonkey randmonkey force-pushed the feat/add_konnect_ref_namespace branch 2 times, most recently from 26c51a5 to 3cfd80f Compare September 19, 2024 08:27
@randmonkey randmonkey requested a review from pmalek September 19, 2024 08:34
@pmalek pmalek force-pushed the feat/add_konnect_ref_namespace branch from 3cfd80f to fc27b30 Compare September 19, 2024 16:03
@randmonkey randmonkey merged commit f5436b2 into main Sep 20, 2024
7 checks passed
@randmonkey randmonkey deleted the feat/add_konnect_ref_namespace branch September 20, 2024 00:11
@pmalek pmalek mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees

@randmonkey randmonkey

Labels
area/konnect
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@randmonkey @pmalek